On Thu, Apr 08, 2021 at 05:39:17PM +0200, Martin Kletzander wrote: > - clang failures: > https://gitlab.com/nertpinx/libnbd/-/jobs/1163504401
I don't usually enable warnings with clang, but I've pushed this which fixes the problem above (and a further one) for me: https://gitlab.com/nbdkit/libnbd/-/commit/28816a5f8829f474d07351611140f461facd0e4d > - golang test failures on OpenSUSE: > https://gitlab.com/nertpinx/libnbd/-/jobs/1163504416 This is actually because: checking for nbdkit... no but we go ahead and run the golang tests anyway. Fixed here: https://gitlab.com/nbdkit/libnbd/-/commit/b15dde588f47894f9656ea62eb632156b7638b8b but there may be more problems after this, we'll see. > - one weird ubuntu 18.04 failure: > https://gitlab.com/nertpinx/libnbd/-/jobs/1163504418 This has golang 1.10 which predates the inclusion of modules. There's basically no sane way to make libnbd work with both old and new golang, so I would suggest --disable-golang on this platform. (In fact is it possible to disable features on different CI platforms?) > and if you want to be able to run `make distcheck` as well, there are > some builddir/srcdir issues in golang/Makefile.am I believe, so VPATH > building actually fails. I added the `make distcheck` step to one of > the jobs here: > > https://gitlab.com/nertpinx/libnbd/-/jobs/1163504412 I think "make distcheck" is a nice-to-have but ISTR that making it work was a lot of work for libguestfs. > In order not to bother you with every single e-mail I would suggest that > I push some incomplete version in the repository and you can see > yourself (and others as well) how the build behaves. What do you say? > I won't look at it earlier than tomorrow anyway. Sure, go for it. Thanks again, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
