On Mon, May 31, 2021 at 09:16:29PM +0200, Martin Kletzander wrote: > The `test` builtin/binary usually accepts `==` for string comparison, it is > mostly accepted for typos and people being used to double equals, but is not > documented and not always accepted either. Since autoconf uses the default > shell, it might just fail in some cases with: > > ./configure: 29986: test: xrustc: unexpected operator > ./configure: 29990: test: xcargo: unexpected operator > > Just change it to single equals as it is done everywhere else. > > Signed-off-by: Martin Kletzander <[email protected]> > --- > m4/guestfs-rust.m4 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/m4/guestfs-rust.m4 b/m4/guestfs-rust.m4 > index aa12a9ef5e5d..1dffd8118874 100644 > --- a/m4/guestfs-rust.m4 > +++ b/m4/guestfs-rust.m4 > @@ -24,8 +24,8 @@ AS_IF([test "x$enable_rust" != "xno"],[ > AC_CHECK_PROG([RUSTC],[rustc],[rustc],[no]) > AC_CHECK_PROG([CARGO],[cargo],[cargo],[no]) > > - AS_IF([test "x$RUSTC" == "xno"], [AC_MSG_WARN([rustc not found])]) > - AS_IF([test "x$CARGO" == "xno"], [AC_MSG_WARN([cargo not found])]) > + AS_IF([test "x$RUSTC" = "xno"], [AC_MSG_WARN([rustc not found])]) > + AS_IF([test "x$CARGO" = "xno"], [AC_MSG_WARN([cargo not found])]) > ],[ > RUSTC=no > CARGO=no
ACK I will push it shortly, thanks. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ _______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
