On Tue, Jun 08, 2021 at 11:01:22AM +0100, Richard W.M. Jones wrote:
I'm lukewarm about patch 3, but all the rest are fine so ACK on those. More comments below:On Tue, Jun 08, 2021 at 09:53:41AM +0200, Martin Kletzander wrote:Lot of clean-ups for the CI. I also added support for easily configurable way of skipping particular tests on selected distros. However, I only skipped those that do not have and easy way of detecting a broken dependency and such like. What is still missing is: - All the CentOS builds have issues with three tests that seem like a protocol violation, but can very well be a bug in some test dependency. Since this is the closest to RHEL we can get, I think it's worth investigating.I can't access the gitlab pipelines at the moment because there's some problem with gitlab+Firefox, but which version of CentOS was this and what kind of problem was it?
That happens to me when I upgrade Firefox and do not restart it. It works for me on FF89. And I looked at the pipelines *a lot* lately =) Anyway, the test-suite.log is available here: https://gitlab.com/nertpinx/libnbd/-/jobs/1326561396/artifacts/file/info/test-suite.log just `curl ... | less` works fine on that link. It mostly complains about: nbdkit: file[1]: error: openat: : No such file or directory ... libnbd: debug: nbd1: nbd_opt_info: leave: error="nbd_opt_info: server replied with error to opt_info request: No such file or directory" couple of times and then ends with: libnbd: debug: nbd1: nbd_shutdown: leave: error="nbd_shutdown: invalid state: CLOSED: the handle must be connected with the server: Invalid argument" libnbd: debug: nbd1: nbd_close: closing handle It happens with info-uri.sh and info-list-uris.sh only. OK, scratch that, I see your reply now, you already looked at it. If that is a bug in nbdkit 1.22, then we can just change the requires of these files to require at least version 1.24.
FWIW I built and testing libnbd and nbdkit on RHEL 7, RHEL 8 and CentOS 9 Stream yesterday. I fixed a few minor things (see commit history) but basically they were all working.- FreeBSDs do not even build and it looks like some libtool wrapper script is fed into a C preprocessor, which fails terribly due to the script comments (but should not be fed there at all, of course.It was building OK for me yesterday (and also on OpenBSD). Do you know what the error was?
There has to be some kind of setup that I we do not replicate in the
- MacOS has issues, although that one is marked to allow failures and the issue does not seem to be on our side anyway. I won't look into it for a while and see if it sorts itself out.I don't have a way to test/reproduce macOS failures but if I could see the failures I might have some ideas.
From my experience it usually just works when it works on FreeBSD, so fixing FreeBSD issues usually helps with that. It turned out I was not properly updating the system before doing anything else. That could also solve the issue above. Since it is an unrelated one-liner I pushed it here: https://gitlab.com/nbdkit/libnbd/-/commit/716d76fdecf6a8f238da5f795a37736fe7377cf2 I rebased this series on top of that and will see how it goes while I incorporate Eric's review.
Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
signature.asc
Description: PGP signature
_______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
