On Tue, Jan 04, 2022 at 01:56:08PM +0000, Richard W.M. Jones wrote:
On Thu, Sep 02, 2021 at 05:12:35PM +0100, Richard W.M. Jones wrote:Hi Martin,On Thu, Sep 02, 2021 at 04:05:56PM +0000, GitLab wrote: > GitLab > ✖ Pipeline #364204388 has failed! > > Project nbdkit / libnbd > Branch ● master > Commit ● 70da51e5 > interop: Link interop-nbd-server-tls with -lgnu... > Commit Author ● Richard W.M. Jones > > Pipeline #364204388 triggered by ● Richard W.M. Jones > had 1 failed job. > Failed jobs > ✖ builds x64-opensuse-tumbleweed > GitLab This is failing on a new test I added, but it's failing because of how a particular package is built in OpenSUSE. The new test is: https://gitlab.com/nbdkit/libnbd/-/commit/c833fa1226092fd51b1211fa195a2a3b791a4ee9 which tries to test libnbd client with TLS enabled against nbd-server. nbd-server in OpenSUSE gives this error: Error: inetd mode requires syslog Exiting. which means it was compiled without --enable-syslog.Hi Martin, this test is failing again: https://gitlab.com/nbdkit/libnbd/-/jobs/1939810938 The error is the same as before: Error: inetd mode requires syslog I guess this is something to do with the new year (see patch below)? We could hack around this again, but I wonder if we could actually fix this properly somehow. Either get OpenSUSE to use --enable-syslog, or
Could be, but: a) my guess is that they do it deliberately b) there might be another distro in the future that we want to support which will have the same issue
somehow try to detect if the binary is not using syslog.
I tried various ways and I can't think of anything else than just trying to run something that will fail like this and then skip the test if it failed.
Rich.I notice that the related test is skipped: SKIP: interop-nbd-server ======================== Test skipped based on ci/skipped_tests file SKIP interop-nbd-server (exit status: 77) The format of ci/skipped_tests is pretty odd. Is this patch OK? diff --git a/ci/skipped_tests b/ci/skipped_tests index e2de9330..c494b9eb 100644 --- a/ci/skipped_tests +++ b/ci/skipped_tests @@ -1,9 +1,9 @@ # Old nbd-server and built without syslog support, tests deadlock, old qemu-img version -^Ubuntu-18\.04$;interop/interop-nbd-server interop/list-exports-nbd-server interop/structured-read.sh -^openSUSE Leap-15;interop/interop-nbd-server interop/list-exports-nbd-server +^Ubuntu-18\.04$;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server interop/structured-read.sh +^openSUSE Leap-15;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server # Similar for Tumbleweed, except tests do not deadlock, only limit to version 2021* for now -^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/list-exports-nbd-server +^openSUSE Tumbleweed-2021;interop/interop-nbd-server interop/interop-nbd-server-tls interop/list-exports-nbd-server # Debian 10 has weird golang issues (old golang anyway) and old qemu-img ^Debian GNU/Linux-10;golang/run-tests.sh interop/structured-read.sh Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top _______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
signature.asc
Description: PGP signature
_______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
