On Sun, Apr 17, 2022 at 09:13:55AM +0200, Laszlo Ersek wrote: > Another style point / simplification has occurred to me the other day > too: in the patch I use the following expression four times: > > ([ device_model ] @ common_props) > > that should be just > > (device_model :: common_props)
The second one is more efficient too. I just checked and ocamlopt 4.13.1 can't optimise the first one at all, there's still an explicit call to camlStdlib__$40 (@). The second one just allocates a cons cell inline. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW _______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
