On 04/20/22 18:47, Richard W.M. Jones wrote: > On Wed, Apr 20, 2022 at 06:23:25PM +0200, Laszlo Ersek wrote: >> + gcaps_default_cpu : bool; >> + (** True iff the guest OS is capable of running on QEMU's default VCPU >> model. > > Can we say “(eg. -cpu qemu64)” here? Might be easier than trying to > parse what QEMU's default VCPU means.
I purposely avoided "qemu64", because the concept applies to "qemu-system-aarch64 -M virt", and qemu64 is not a VCPU model there. (NB in the output modules, "-cpu host" *does* make sense for the Virt machine type, and I think the libvirt domain XML fragment is arch-agnostic as well.) (Similarly, the check in convert-linux is also restricted to the x86_64 guest arch; aarch64 RHEL9 does not have this problem to my knowledge.) I can of course say '(eg. "-cpu qemu64" with the Q35 and I440FX machine types)'; so I'll do that. Thanks! Laszlo > > Rest looks fine, so: > > Reviewed-by: Richard W.M. Jones <[email protected]> > > Rich. > _______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
