Patch 1 seems uncontroversial. Patch 2 is tricky. This is related to the following RFE: https://github.com/libguestfs/libguestfs/issues/80
I initially believed that the reporter wanted to just associate some general data per drive, and wanted to reuse the (unused) name field for this. That's what this patch implements. However I since believe that he's in fact trying to just get the drive name of the drive that was just added. There's no need for any API for that, you can just assume drives are called (from the guestfs API point of view) /dev/sda, /dev/sdb etc. Adding patch 2 probably confuses things, since I guess most people would assume that an API called guestfs_get_drive_name would return the drive name (/dev/sda) not some string that you have to add. Rich. _______________________________________________ Libguestfs mailing list [email protected] https://listman.redhat.com/mailman/listinfo/libguestfs
