On Thu, Sep 01, 2022 at 03:46:23PM -0500, Eric Blake wrote: > On Thu, Sep 01, 2022 at 09:53:11AM +0200, Laszlo Ersek wrote: > > On 08/31/22 16:39, Eric Blake wrote: > > > As promised in the previous patch, also test the new > > > nbd_opt_set_meta_context() API in Python, OCaml, and Golang. > > > > > > The fact that Go slams all unit tests into the same namespace is > > > somewhat annoying; it required munging test 240 now that 250 wants to > > > use similar global variables. > > > --- > > > python/t/250-opt-set-meta.py | 126 ++++++++++++ > > > ocaml/tests/Makefile.am | 5 +- > > > ocaml/tests/test_250_opt_set_meta.ml | 150 ++++++++++++++ > > > tests/opt-set-meta.c | 1 + > > > golang/Makefile.am | 3 +- > > > golang/libnbd_240_opt_list_meta_test.go | 54 +++--- > > > golang/libnbd_250_opt_set_meta_test.go | 248 ++++++++++++++++++++++++ > > > 7 files changed, 558 insertions(+), 29 deletions(-) > > > create mode 100644 python/t/250-opt-set-meta.py > > > create mode 100644 ocaml/tests/test_250_opt_set_meta.ml > > > create mode 100644 golang/libnbd_250_opt_set_meta_test.go > > > > git-am reports the following whitespace errors on this patch: > > > > .git/rebase-apply/patch:579: space before tab in indent. > > t.Fatalf("unexpected structured replies state") > > I don't know if emacs has a handy auto-formatter that follows rust's > preferred styles. Will fix the patch, whether or not I find a way to > make emacs do it for me.
Sorry, make that Go's preferred styles. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs