On 09/09/22 15:04, Richard W.M. Jones wrote: > On Fri, Sep 09, 2022 at 02:53:11PM +0200, Laszlo Ersek wrote: >> On 09/09/22 13:51, Richard W.M. Jones wrote: >>> On Fri, Sep 09, 2022 at 11:10:47AM +0200, Laszlo Ersek wrote: >>>> On 09/08/22 18:27, Laszlo Ersek wrote: >>>>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1590721 >>>>> v1: >>>>> https://listman.redhat.com/archives/libguestfs/2022-September/029806.html >>>>> >>>>> Please see the Notes section on each patch for the updates in this >>>>> version (addressing v1 feedback). Patch #5 is a candidate for dropping >>>>> in particular. >>>>> >>>>> I'm also including a range-diff between v1 and v2, below. >>>>> >>>>> [...] >>>> >>>> I meant to append: v2 builds fine at every stage again, and I retested >>>> full conversions too, with both states of the new boolean knob. >>> >>> Updated series is fine, thanks. >> >> Should I drop patch#5? Dropping #5 seems to follow directly from >> Daniel's suggestion, and I wanted to clear it with you before merging. > > That's the one which sets the default? I don't have a preference or > enough knowledge on this to say which is best, whatever you think.
OK, I've dropped patch#5. Commit range 0687cea6a86e..6f1adeba1aab. Laszlo _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
