On 09/23/22 11:54, Richard W.M. Jones wrote: > ACK series, but see my comment about patch 14.
Thanks, I'll adjust patch 14 before pushing (I believe I now understand the borders in the docs). > > A couple of other general points: > > (1) You could copy the vector type from nbdkit if that would help with > handling lists of strings. For now I'd like to stick with the string lists. They're quite native to libguestfs (is my feeling anyway), and the macro trickery around the vector type in libnbd / nbdkit always makes it difficult for me to jump to the actual function definitions. > (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v > to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, > which even for Gtk 2 is an old version. Those RHEL releases had > support for some old hardware, especially some old HP Smart Array > devices, which was dropped in newer RHEL, making it impossible to > convert physical machines using those devices. > > However the move to PCRE2 means that we can no longer compile on RHEL 6 > (RHEL 7 is still OK). Gtk2 itself went out of support in 2021 [0], > although that is not very relevant. > > If we had a customer who wanted support for the old devices, perhaps > it is better to look for a modern distro that still supports them and > would have Gtk 3, PCRE 2, etc. Perhaps Fedora or Debian. I'll look into removing gtk2 support from virt-p2v. Laszlo _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
