We previously checked only that String parameters are not NULL, returning an error + EFAULT if so.
However we did not check Bytes*, SockAddrAndLen, Path or StringList parameters, also never NULL. I'm not sure if we ought to be checking parameters for NULL like this at all (preferring instead to simply crash), but at least let's be consistent about it. --- generator/C.ml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/generator/C.ml b/generator/C.ml index 4f758e526f..87ed5969ff 100644 --- a/generator/C.ml +++ b/generator/C.ml @@ -612,7 +612,12 @@ let need_out_label := true | Flags (n, flags) -> print_flags_check n flags None - | String n -> + | BytesIn (n, _) | BytesOut (n, _) + | BytesPersistIn (n, _) | BytesPersistOut (n, _) + | SockAddrAndLen (n, _) + | Path n + | String n + | StringList n -> let value = match errcode with | Some value -> value | None -> assert false in -- 2.37.0.rc2 _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs