On Sat, Sep 09, 2023 at 02:57:54PM +0100, Richard W.M. Jones wrote: > Almost always when you used nbdkit --run you should also use -U - (to > use a private Unix domain socket). Otherwise nbdkit listened on TCP > port 10809, which had two bad side effects: It permitted other > processes to interfere with your --run command, and it reserved a > public TCP port which would stop two instances of nbdkit running at > the same time. This was a frequent cause of bugs in test cases.
Indeed, I can easily find a number of commits where we added -U- after the fact because of testsuite failures ;) > > Switch the default so now --run implies -U - > > You can still get the old behaviour by using --port explicitly, but > that is almost certainly a bad idea. (Using --run and --vsock works > the same way as before too. It is also usually a bad idea, although > we use it in one test.) > --- > docs/nbdkit-captive.pod | 7 ------- > docs/nbdkit.pod | 9 ++++++++- > server/main.c | 9 +++++++++ > 3 files changed, 17 insertions(+), 8 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
