On Thu, Sep 21, 2023 at 03:56:05PM +0200, Laszlo Ersek wrote: ... > > +open Std_utils > > + > > +(* Does [file] support the [-S] / [--no-sandbox] option > > + * (not on OpenSUSE LEAP 15). > > + *) > > +let file_has_S_option = lazy ( > > + let out = Utils.command "file" ["file"; "--help"] in > > I think this executes "file file --help", which happens to work, but the > intent is probably just "file --help". (IOW, IMO this should be > > Utils.command "file" ["--help"] > > .)
Indeed it does. BTW I did check this patch by running: $ make && LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 make -C tests/ check TESTS=c-api/tests and examining tests/c-api/tests.log, and that shows that file --help (or rather, "file file --help") is being run exactly once, and the -S option was still being included in the parameters. > Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks, I'll tidy up and fix the things you mentioned. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
