Commit 1b5e42ad16ab3df69283f114a7822e3e7fbc238a changed the run_tests
script to change the number of threads for the linkshare test based on
the available hugepages.
This was done to allow the test to run on systems without vast
quantities of hugepages, but it's not the best approach. For one
thing it will happily reduce the number of threads to 1, which rather
defeats the purpose of a sharing test. It also makes unwarranted
assumptions about how much memory the given test program ($baseprog)
needs.
The real problem was that originally we were arbitrarily running 10
threads, for no particular reason. In accordance with the principle
of minimal testcases (at least for the "functional" section of the
testsuite), this patch removes the adaptive number of threads logic
and just runs 2 threads - the minimum number we need to have a
meaningful test of the elflink sharing code.
Signed-off-by: David Gibson <[EMAIL PROTECTED]>
Index: libhugetlbfs/tests/run_tests.sh
===================================================================
--- libhugetlbfs.orig/tests/run_tests.sh 2006-10-24 16:05:10.000000000
+1000
+++ libhugetlbfs/tests/run_tests.sh 2006-10-24 16:05:33.000000000 +1000
@@ -64,7 +64,7 @@ elfshare_test () {
baseprog="${args[$N]}"
unset args[$N]
set -- "[EMAIL PROTECTED]"
- NUM_THREADS=$((`free_hpages` / 15 - 1))
+ NUM_THREADS=2
killall -HUP hugetlbd
run_test HUGETLB_SHARE=2 "$@" "xB.$baseprog" $NUM_THREADS
killall -HUP hugetlbd
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
