On Mon, Nov 13, 2006 at 04:01:01PM -0800, Nishanth Aravamudan wrote:
> On 14.11.2006 [10:17:25 +1100], David Gibson wrote:
> > On Mon, Nov 13, 2006 at 10:06:19AM -0800, Nishanth Aravamudan wrote:
> > > On 12.11.2006 [11:19:23 +1100], David Gibson wrote:
> > > > On Fri, Nov 10, 2006 at 11:43:56AM -0800, Nishanth Aravamudan wrote:
> > > > > Fix linkshare testcase to catch the case where the sharing children 
> > > > > are
> > > > > killed by a signal. Currently, if a child segfaults, we still PASS the
> > > > > test, when it clearly should be a FAIL case.
> > > > 
> > > > Um.. yes, we certainly want this.
> > > 
> > > Yep, and my solution is incomplete -- we actually want a SIGSEGV
> > > handler, as that has been (in my testing), the only way to reliably
> > > catch this fail-case on x86_64. Would it make sense to globally install
> > > one in test_init(), like we do for SIGINT?
> > 
> > Huh?  Why does AMD64 need a SEGV handler?
> 
> Sorry, I may have been unclear hear, but linkshare is segfaulting on my
> x86_64 box (and others). Try running make check, then check dmesg,
> you'll see.

Oh, not just a SEGV but an oops then, if it's showing up in dmesg.  I
don't think a SEGV handler will even catch that.

But in any case, I'm not particularly worried about bad failures
showing up as SEGVs.  I don't see how the top level testcase can PASS
in this case.  I consider the overall pass condition for the testsuite
to be "all tests PASS, *and* there are no deaths by signal or kernel
explosions during the run".

We do, of course, need to work out why the test is SEGVing in the
first place and fix it.  And if the kernel is oopsing, fix that
regardless of what the testcase is doing.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to