On 14.11.2006 [13:39:54 +1100], David Gibson wrote: > On powerpc with 4K base page size, the truncate_above_4GB test fails > in an uninteresting way (i.e. not because of the bug it was designed > to catch). This because the 'buggy_offset' it calculates is not > hugepage aligned, so the map at this offset (correctly) fails. > > This patch rounds the offset up to a hugepage size to avoid this. > According to Hugh Dickins who provided the initial testcase, this > still ought to catch the original problem. It's more-or-less > impossible to test, though, since the bug only ever showed up on > 32-bit archs, i.e. on i386 and on i386 the pagesizes are such that the > calculation doesn't result in a misaligned offset. > > While we're at it, this patch adds some more detailed verbose_printf() > statements to make tracking down test failures easier. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]>
Applied, thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel