On 03.01.2007 [14:20:38 -0800], Nishanth Aravamudan wrote: > On 03.01.2007 [10:27:19 +1100], David Gibson wrote: > > On Tue, Jan 02, 2007 at 03:03:00PM -0800, Nishanth Aravamudan wrote: > > > Some of our error and debugging paths are missing newlines, which makes > > > for confusing output when things are misconfigured. Make sure all > > > ERROR and WARNING in the library is properly terminated. > > > > Actually, I think the right way to fix this is to remove \n from any > > ERROR() and WARNING() macros that do have then, and add them back in > > the macro itself. I'm pretty sure the reason I've made these errors > > is because I was assuming that ERROR() and WARNING() added the \n, > > like CONFIG() and FAIL(), which in turn work that way because perror() > > does. > > I disagree with this, just because it means we, for instance, in the > case with my other patch to *remove* a newline, will now need to provide > another set of non-newlined macros...
And hence, I merged my original patch. With the understanding that it would be worth looking into your idea post 1.0.2. Thanks, Nish -- Nishanth Aravamudan <[EMAIL PROTECTED]> IBM Linux Technology Center ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Libhugetlbfs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
