On 23.01.2007 [09:57:01 -0600], Adam Litke wrote:
> On Mon, 2007-01-22 at 16:20 -0800, Nishanth Aravamudan wrote:
> > On 22.01.2007 [17:08:34 -0600], Adam Litke wrote:
> > > The current extracopysize detection algorithm does not include weak
> > > objects in the copy window. These are symbols marked with 'W' and 'V'
> > > in nm output. These can in fact be initialized global variables (just
> > > like STB_GLOBAL symbols) and should be included in the extracopy window.
> > >
> > > The following patch adds STB_WEAK symbols to the extracopy window.
> > > Since the if statement is getting a bit large and out of hand, move the
> > > logic out of the function and into its own macro "keep_symbol".
> > >
> > > This patch resolves an eon (speccpu2000 benchmark) failure.
> > >
> > > Signed-off-by: Adam Litke <[EMAIL PROTECTED]>
> > >
> > > diff --git a/elflink.c b/elflink.c
<snip>
> > > + (ELF_ST_TYPE(sym->st_info) == STT_OBJECT) && \
> >
> > typo --^ ? Shouldn't that be s->st_info, not sym->st_info?
>
> Oops! That's what I get for trying to hustle this out the door right at
> the end of the day.
Heh, no worries.
<snip>
> > Something like
> >
> > static inline int keep_symbol(Elf_Sym *s)
> > {
...
> > }
>
> Sure. I am fine with that too. Want to handle it directly or shall I
> spin another patch?
If you could spin one more, I'd appreciate it.
Thanks,
Nish
--
Nishanth Aravamudan <[EMAIL PROTECTED]>
IBM Linux Technology Center
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
