On Tue, Feb 06, 2007 at 03:02:50PM -0600, Steve Fox wrote:
> On Tue, 2007-02-06 at 13:41 +1100, David Gibson wrote:
> > On Mon, Feb 05, 2007 at 08:30:26PM -0600, Steve Fox wrote:
> > > I found that on SLES10 PPC that the stack_grow_into_huge test would not
> > > stop the child process, even with the barrier hack. The below patch
> > > changes the test so that if the child doesn't die within 5 seconds, we
> > > kill it and fail the test. It still returns immediately if the child is
> > > terminated as expected with a proper kernel.
> >
> > Better to have a test in the child, I think, that means it only
> > attempts to grow the stack so far than to use a timer.
>
> That would make it dependent on architecture and bitness which seems
> rather fragile to me.
Whereas timing depends on system speed and load, which seems even more
fragile. There are slow embedded boards which can use hugetlb...
In any case, this test was really designed to check a specific case,
as long as we attempt to grow the stack to below the hugepage mapping
we set up for it to collide with, we should be ok.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
