On Mon, 2007-09-17 at 20:22 +0300, Mika Penttilä wrote:
> > +void return_unused_surplus_pages(void)
> > +{
> > + static int nid = -1;
> > + int delta;
> > + struct page *page;
> > +
> > + delta = unused_surplus_pages - resv_huge_pages;
> > +
> > + while (delta) {
> >
> Shouldn't this be while (delta >= 0) ?
unused_surplus_pages is always >= resv_huge_pages so delta cannot go
negative. But for clarity it makes sense to apply the change you
suggest. Thanks for responding.
> > + nid = next_node(nid, node_online_map);
> > + if (nid == MAX_NUMNODES)
> > + nid = first_node(node_online_map);
> > +
> > + if (!surplus_huge_pages_node[nid])
> > + continue;
> > +
> > + if (!list_empty(&hugepage_freelists[nid])) {
> > + page = list_entry(hugepage_freelists[nid].next,
> > + struct page, lru);
> > + list_del(&page->lru);
> > + update_and_free_page(page);
> > + free_huge_pages--;
> > + free_huge_pages_node[nid]--;
> > + surplus_huge_pages_node[nid]--;
> > + unused_surplus_pages--;
> > + delta--;
> > + }
> > + }
> > +}
> > +
>
> --Mika
>
>
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
