On Thu, Apr 10, 2008 at 04:50:22PM -0500, Jon Tollefson wrote:
> This patch moves the check of the return value from gethugepagesize() to a
> common function, check_hugepagesize(),
> rather then repeating it in each test. gethugepagesize() is updated to set
> errno depending on the reason for the failure.
>
> Only tests that were already calling gethugepagesize() are calling
> check_hugepagesize(). Attached also is the output of the test suite run with
> 16G pages on POWER before this change and after.
>
> Changes since v4
> -save errno so that the same value can be returned on every call to
> gethugepagesize()
> -removed check_hugepagesize() call in linkhuge and linkshare since the
> return will be checked in morecore and elflink in part 2 of this patch
> -removed the call_gethugepagesize() function since linkhuge and
> linkshare no longer need it
>
> Changes since v3
> -incorporated Mel Gorman's function that uses dlopen so that
> tests don't have to be linked against libhugetlbfs
Urg... I'm actually really dubious about this dlopen() idea. By
definition we're using this on tests that aren't supposed to be linked
against libhugetlbfs. I'm worried that for certain edge cases sucking
in the library with dlopen(), even if it's not fully linked in could
make the behaviour different, from something that really doesn't have
libhugetlbfs present. Or that the use of dlopen() might mask a
breakdown in the PRELOAD or other mechanism we use to pull the library
in in when it's supposed to be there.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
