On Thu, Apr 10, 2008 at 05:48:40PM -0700, Nishanth Aravamudan wrote:
> > - WARNING("Failed to reserve huge pages in "
> > - "hugetlbfs_morecore()\n");
> > + WARNING("Failed to allocate %ld huge pages "
> > + "for heap\n", delta/blocksize);
>
> I'd prefer to keep the reserve terminology here. It indicates a
> fairly well-defined failpoint. So simply s/allocate/reserve/ in your
> line.
OK.
> Technically speaking, heap is also inaccurate. It's really for any
> dynamic allocation, not necessarily just for the heap.
I'm not sure what you mean. Can more than malloc call the morecore hook?
I have always associated malloc with "heap".
> > - WARNING("Unmapping failed in hugetlbfs_morecore(): "
> > + WARNING("Heap shrink unmapping failed: "
> > "%s\n", strerror(errno));
> > - WARNING("Couldn't truncate hugetlbfs file in "
> > - "hugetlbfs_morecore(): %s\n",
> > - strerror(errno));
> > + WARNING("Couldn't truncate hugetlbfs file for"
> > + " heap shrink: %s\n", strerror(errno));
>
> I think these last two can still be phrased better.
>
> How about:
>
> "Unmapping failed while shriking heap: "
>
> and
>
> "Could not truncate hugetlbfs file to shrink heap: "
>
> ?
OK.
New patch soon.
Dean
Dean Luick
Cray Inc.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
