On Mon, Jun 30, 2008 at 01:43:58PM -0700, Nishanth Aravamudan wrote:
> David,
>
> On 18.06.2008 [14:48:16 +1000], David Gibson wrote:
> > Adam, Nish, Jon,
> >
> > Just noticed this today when running the hugepage tests for someone.
> >
> > We've now implemented the new -z based relinking method - good show.
> > But the testsuite only exercises the old linker script based
> > approach. Not cool.
> >
> > The testsuite is a great tool but it won't stay that way if it's not
> > kept updated to refelect the current state of the library. Don't
> > treat it as an afterthought - put tests for anything new you're doing
> > into the testsuite as you're doing the implementation. Don't use
> > ad-hoc testing with the intention of intergrating it later, merge it
> > into the automated tests straight away. It will make your life easier
> > during developement, and everyone's life easier later on.
>
> Thanks for the note. Sorry for the delay in responding, I've been on
> vacation for the past month.
>
> You are right on the testsuite side of things. I believe the reason we
> didn't enable the new relinking for the tests is because of a binutils
> dependency which we weren't positive how best to test automatically for.
> I believe a patch will be forthcoming to add such a check to the
> build/test and I don't plan on releasing 2.0 until that exists.
Ok, good. Sorry to send GrumpyMail.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
