On Wed, 2008-07-16 at 22:47 +0100, Mel Gorman wrote:
> > +   if (fd < 0) {
> > +           ERROR("kernel_has_private_reservations: hugetlbfs_unlinked_fd: "
> > +                   "%s\n", strerror(errno));
> > +           return -1;
> > +   }
> > +   map = mmap(NULL, gethugepagesize(), PROT_READ|PROT_WRITE, MAP_PRIVATE, 
> > fd, 0);
> > +   if (map == MAP_FAILED) {
> > +           ERROR("kernel_has_private_reservations: mmap: %s\n",
> > +                   strerror(errno));
> > +           return -1;
> > +   }
> 
> Why is this an error? It implies that the kernel supports private
> reservations bu the pool is empty.

You are right.. It probably means that.  I just wasn't convinced that
private reservations were the only thing that could cause that mmap to
fail and wanted to avoid a false positive.


-- 
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to