On Thu, Jul 31, 2008 at 09:01:29AM -0500, Adam Litke wrote:
> On Thu, 2008-07-31 at 10:54 +1000, David Gibson wrote:
> > On Wed, Jul 30, 2008 at 07:15:54PM +0000, Adam Litke wrote:
> > > The /proc/mounts parsing code cannot handle a file larger than 4k in size.
> > > Since the data in this file is line-oriented, read the file line by line
> > > and
> > > stop after the first valid hugetlbfs mount point is found. This fixes the
> > > large_mounts test case.
> >
> > Um.. isn't stopping at the first valid mount insufficient with the
> > multiple mountpoints / pagesizes support?
>
> In order to fix the large_mounts test, I was asked to split the multiple
> mount points patch so that the fixed /proc/mounts parsing code could be
> released in libhuge-2.0. So for this port, we want to maintain current
> behavior (which is to keep only the first mount point). The rest of the
> multiple mounts support can be easily added after the libhugetlbfs-2.0
> release.
Ah, ok. It seems to be working again in today's pull.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
