On (10/10/08 13:14), Andy Whitcroft didst pronounce:

> > > +
> > > +int select_pool_counter(unsigned int counter, unsigned long pagesize,
> > > +                         char *filename, char **key)
> > > +{
> > 
> > /*
> >  * Return the value of a given counter (e.g. HUGEPAGES_RSVD) for the
> >  * of the requested pagesize. This ordinarily will use a sysfile in
> >  * /sys/kernel/mm/hugepages/hugepages-NNKB/ but in the case of the
> >  * default pagesize may read the Hugepagesize: key in /proc/meminfo.
> >  * The filename and key (if applicable) used is returned to the caller.
> >  */
> > 
> 
> Thats not quite right as it does not return the value of any counter.
> It only tells us the filenames and tags.  How about this:
> 
> /*
>  * Pool counters are typically exposed in sysfs in modern kernels, the
>  * counters for the default page size are exposed in procfs in all kernels
>  * supporting hugepages.  Given a specific counter (e.g. HUGEPAGES_RSVD)
>  * and a page size return both a filename and an optional tag to locate 
>  * and extract this counter.
>  */
> 

Perfect. Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to