On Fri, Oct 10, 2008 at 02:10:21PM -0500, Adam Litke wrote:
> On Fri, 2008-10-10 at 16:58 +0100, Andy Whitcroft wrote:
> > diff --git a/libhugetlbfs_internal.h b/libhugetlbfs_internal.h
> > index 197fa05..2912c5e 100644
> > --- a/libhugetlbfs_internal.h
> > +++ b/libhugetlbfs_internal.h
> > @@ -89,6 +89,15 @@ struct hpage_size {
> > char mount[PATH_MAX+1];
> > };
> >
> > +struct hpage_pool {
> > + unsigned long pagesize_kb;
>
> I just noticed this while reviewing the next patch. Awhile back I
> switched from storing the page size in kb to always storing it in bytes.
> This was to avoid confusion and promote consistency when handling page
> size values. Could we maintain that convention in this struct as well?
Worse so did I, and this value is in bytes. It was on my list to fix,
and it got missed.
> > + unsigned long minimum;
> > + unsigned long maximum;
> > + unsigned long size;
> > +};
> > +
> > +extern int __lh_hpool_sizes(struct hpage_pool *, int);
> > +
> > /* Arch-specific callbacks */
> > extern int direct_syscall(int sysnum, ...);
> > extern ElfW(Word) plt_extrasz(ElfW(Dyn) *dyntab);
-apw
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
