On Mon, Oct 20, 2008 at 10:14:54PM +0000, Adam Litke wrote:
> Andy Whitcroft had some good suggestions on my check_linkhuge_tests patch.
> - Comment the format of LINKHUGE_WORDSIZES
> - Use a case statement instead of an if/else
>
> Signed-off-by: Adam Litke <[EMAIL PROTECTED]>
Acked-by: Andy Whitcroft <[EMAIL PROTECTED]>
Much clearer with that comment in there.
> ---
>
> tests/run_tests.sh | 14 ++++++++------
> 1 files changed, 8 insertions(+), 6 deletions(-)
>
>
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index dc2370f..5b2a955 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -81,6 +81,10 @@ function check_linkhuge_tests() {
> # system linker scripts use the SPECIAL keyword (for placing the got and
> # plt). Our linker scripts do not use SPECIAL and are thus broken when
> the
> # system scripts use it.
> +
> + # LINKHUGE_WORDSIZES is a copy of WORDSIZES with the exception that any
> + # word sizes for which the linkhuge tests should be skipped are prefixed
> + # with 'no' (ie. LINKHUGE_WORDSIZES="32 no64"
> LINKHUGE_WORDSIZES=""
> for bits in $WORDSIZES; do
> gcc -m$bits -Wl,--verbose 2> /dev/null | grep -q SPECIAL
> @@ -89,7 +93,6 @@ function check_linkhuge_tests() {
> fi
> LINKHUGE_WORDSIZES="$LINKHUGE_WORDSIZES $bits"
> done
> -echo "LINKHUGE_WORDSIZES = $LINKHUGE_WORDSIZES"
> }
>
> run_test_bits () {
> @@ -141,11 +144,10 @@ skip_test () {
>
> maybe_run_linkhuge_test () {
> for bits in $LINKHUGE_WORDSIZES; do
> - if [ "$bits" == "${bits#no}" ]; then
> - run_test_bits $bits "$@"
> - else
> - skip_test_bits ${bits#no} "$@"
> - fi
> + case "$bits" in
> + no*) skip_test_bits ${bits#no} "$@" ;;
> + *) run_test_bits $bits "$@" ;;
> + esac
> done
> }
-apw
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
