On Wed, Oct 22, 2008 at 04:59:52PM +0100, Andy Whitcroft wrote: > Following this email are 5 patches. The come out of the work to fix up > hugeadm to handle older kernels without overcommit support. The first > two are basically bug fixes. The third represents the fixes needed to > handle overcommit being missing, essentially making maximum track minimum > at all times. The forth makes hugeadm behave more sensibly when run on > a kernel which does not support hugepages at all. The last is a proposed > cleanup to use a common cached value for the kernel default page size as > we look it up very often and it is not cheap. > > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Other than a whitespace oddity, everything looked good reading through. For the whole set. Acked-by: Mel Gorman <[EMAIL PROTECTED]> > > Andy Whitcroft (5): > counters: we should be using size_to_smaller_unit to convert units > hugeadm: emit the usage is no operations are specified > hugeadm: cleanup pool size adjustment for kernels without overcommit > hugeadm: check for and report the lack of hugepage support in the > kernel > privutils: expose the kernel default page size > > hugeadm.c | 34 +++++++++++++++++++++-- > hugeutils.c | 67 ++++++++++++++++++++++++++++++++++++++++----- > libhugetlbfs_privutils.h | 9 ++++++ > shm.c | 2 +- > 4 files changed, 100 insertions(+), 12 deletions(-) > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
