Eric B Munson wrote:
> On Fri, 07 Nov 2008, Jon Tollefson wrote:
>
>   
>> Eric B Munson wrote:
>>     
>>> Some of the test suite will fail unexpectedly when the overcommit pool has
>>> any pages allocated.  This patch introduces a simple method for saving and
>>> restoring the size of the overcommit pool so these tests can 0 it before
>>> running.
>>>
>>> Signed-off-by: Eric B Munson <[EMAIL PROTECTED]>
>>> ---
>>>  hugeutils.c              |   16 ++++++++++++++++
>>>  libhugetlbfs_privutils.h |    6 ++++++
>>>  2 files changed, 22 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hugeutils.c b/hugeutils.c
>>> index 1121966..791aa37 100644
>>> --- a/hugeutils.c
>>> +++ b/hugeutils.c
>>> @@ -874,6 +874,22 @@ int set_nr_overcommit_hugepages(long pagesize, 
>>> unsigned long val)
>>>     return set_huge_page_counter(pagesize, HUGEPAGES_OC, val);
>>>  }
>>>
>>> +long save_overcommit_pages(long page_size)
>>>   
>>>       
>> This function name seems misleading since the function isn't actually
>> saving anything.  Would it make sense for the function to save the value
>> in a variable and then use that value later in the restore function?
>>
>> Jon
>>     
>
> How about read_nr_overcommit?
>
> Eric
>   
Yeah, that makes sense for the function as it is.

Jon


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to