On Wed, Nov 12, 2008 at 12:32:44PM +0000, Mel Gorman wrote:
> On Tue, Nov 11, 2008 at 10:45:08PM +1100, David Gibson wrote:
> > On Mon, Nov 10, 2008 at 11:55:31AM +0000, Mel Gorman wrote:
> > > It has been asserted that the name get_huge_pages() implies the API is
> > > a close-to-kernel interface for allocating hugepages and nothing else.
> > > In 2.1-preX, this definition does not fit as it allows fallback to base
> > > pages
> > > for example. This patch enforces the meaning implied by the function
> > > name by
> > > removing the ability of the function to fallback to base pages and
> > > redefines
> > > GHP_DEFAULT to mean "Use the default hugepage size to back the
> > > region".
> >
> > Um, yeah. My same wish to keep get_huge_pages() simple and low-level
> > is why I was dubious about having it fallback to normal pages in the
> > first place. I may not have expressed this thought very well at the
> > time, which might account for why our views of the interface had
> > diverged so greatly this time around.
>
> I agree that we had fairly different ideas of what the interface would
> mean but I think we're on the same page now?
Yeah, I think so.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
