Alright. This stuff looks pretty good to me. I think we should create a new branch for post-2.1 stuff and this could get committed there. Things like this and the run_tests rework I am doing will need a longer testing cycle than usual because unexpected things are bound to break.
On Thu, 2008-11-06 at 17:43 +0000, Eric B Munson wrote: > This patch set movaes all library calls to getenv in to a single setup > function which is called onc during library initialisation. When value > parsing is simplistic (e.g. atoi of the env value) the parsing was also > moved in the new function, however in cases where the parsing was more > involved or hinged on other values the parsing was left in place to > minimize impact on parsing logic. The shmoverride_* tests relied on > envrinoment variable parsing happening each time the value was read. > This patch removes that behavior as the environment is only read once > the the shmoverride tests have been updated appropriately. > > Comments? > > --Signed-of-by: Eric B Munson <[EMAIL PROTECTED]> > > Eric B Munson (7): > Create environment parse function and value storage struct > Move debug env parsing to new function > Move the elfmap env parsing into setup_env function > Move all getenv calls from various function in hugeutils into > hugetlbfs_setup_env > Moving Morecore env parsing to new function > Move shm env parsing to new function > Fix shmoverride tests for single env parsing > > debug.c | 14 ------ > elflink.c | 70 ++++++++++++------------------- > hugeutils.c | 94 ++++++++++++++++++++++++++++++++++++----- > init.c | 1 + > kernel-features.c | 13 +++--- > libhugetlbfs_internal.h | 20 +++++++++ > morecore.c | 44 +++++--------------- > shm.c | 11 +---- > tests/run_tests.sh | 6 ++- > tests/shmoverride_unlinked.c | 36 ++++++++++------ > 10 files changed, 177 insertions(+), 132 deletions(-) > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Libhugetlbfs-devel mailing list > Libhugetlbfs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel > -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
