On Fri, Nov 14, 2008 at 09:01:03PM +0000, Adam Litke wrote:
>
> ---
>
> shm.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/shm.c b/shm.c
> index ac3b52a..5e96400 100644
> --- a/shm.c
> +++ b/shm.c
> @@ -38,7 +38,7 @@ int shmget(key_t key, size_t size, int shmflg)
> size_t aligned_size = size;
> int hugetlbshm_enabled = 0;
>
> - DEBUG("hugetlb_shmem: entering overridden shmget() call\n");
> + INFO("hugetlb_shmem: entering overridden shmget() call\n");
>
> /* Get a handle to the "real" shmget system call */
> if (!real_shmget) {
Ah, this is a trace message. Does it really need to be info?
> @@ -63,11 +63,11 @@ int shmget(key_t key, size_t size, int shmflg)
> long hpage_size = kernel_default_hugepage_size();
> aligned_size = ALIGN(size, hpage_size);
> if (size != aligned_size) {
> - DEBUG("hugetlb_shmem: size growth align %zd -> %zd\n",
> + INFO("hugetlb_shmem: size growth align %zd -> %zd\n",
> size, aligned_size);
> }
Similar here.
>
> - DEBUG("hugetlb_shmem: Adding SHM_HUGETLB flag\n");
> + INFO("hugetlb_shmem: Adding SHM_HUGETLB flag\n");
> shmflg |= SHM_HUGETLB;
> } else {
Although this change is ok because it'll be a one-line indicator at INFO
level that something useful is happening.
> DEBUG("hugetlb_shmem: shmget override not requested\n");
> @@ -80,7 +80,7 @@ int shmget(key_t key, size_t size, int shmflg)
> aligned_size, strerror(errno));
> shmflg &= ~SHM_HUGETLB;
> retval = real_shmget(key, size, shmflg);
> - DEBUG("Using small pages for shmget despite HUGETLB_SHM\n");
> + WARNING("Using small pages for shmget despite HUGETLB_SHM\n");
> }
>
Ok
> return retval;
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Libhugetlbfs-devel mailing list
> Libhugetlbfs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
