On Mon, 2008-11-17 at 17:28 +0000, Mel Gorman wrote:
> On Fri, Nov 14, 2008 at 09:00:50PM +0000, Adam Litke wrote:
> >
> > ---
> >
> > alloc.c | 8 +++++---
> > 1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/alloc.c b/alloc.c
> > index 750b2cb..f231f2c 100644
> > --- a/alloc.c
> > +++ b/alloc.c
> > @@ -35,7 +35,7 @@ static void *fallback_base_pages(size_t len, ghp_t flags)
> > {
> > int fd;
> > void *buf;
> > - DEBUG("get_huge_pages: Falling back to base pages\n");
> > + INFO("get_huge_pages: Falling back to base pages\n");
> >
> > /*
> > * Map /dev/zero instead of MAP_ANONYMOUS avoid VMA mergings. Freeing
>
> This will collide with the recent changes to the allocator but it's a
> trivial resolution.
>
> > @@ -46,7 +46,8 @@ static void *fallback_base_pages(size_t len, ghp_t flags)
> > */
> > fd = open("/dev/zero", O_RDWR);
> > if (fd == -1) {
> > - ERROR("get_huge_pages: Failed to open /dev/zero for fallback");
> > + WARNING("get_huge_pages: Failed to open /dev/zero for "
> > + "fallback");
> > return NULL;
>
> Actually, is this is still an error? The library has encountered a
> situation where it cannot recover and is depending on the caller to do
> something useful.
Sure. I'll switch it back.
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
