On Fri, Jan 30, 2009 at 05:28:01PM +0000, Eric B Munson wrote:
> This option allows the user to request that all instances of the target
> program should share their read-only segments that are remapped to
> huge pages.
>
> Signed-off-by: Eric B Munson <ebmun...@us.ibm.com>
> ---
> hugectl.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/hugectl.c b/hugectl.c
> index 3497258..1522cba 100644
> --- a/hugectl.c
> +++ b/hugectl.c
> @@ -73,6 +73,8 @@ void print_usage()
> OPTION("--dry-run", "describe what would be done without doing it");
>
> OPTION("--library-use-path", "Use the system library path");
> + OPTION("--share-text", "Allow the text segement to be shared if");
> + CONT("it is backed by huge pages.");
segment spelt wrong.
The description also does not tell me more about the switch than the
name itself. Maybe describe it as "Share text segments between multiple
application instances" ?
> OPTION("--library-path <path>", "Select a library prefix");
> CONT("(Default: "
> #ifdef LIBDIR32
> @@ -150,6 +152,7 @@ void verbose_expose(void)
>
> #define LONG_DRY_RUN (LONG_BASE | 'd')
>
> +#define LONG_SHARE (LONG_BASE | 's')
> #define LONG_NO_LIBRARY (LONG_BASE | 'L')
> #define LONG_LIBRARY (LONG_BASE | 'l')
>
> @@ -320,6 +323,7 @@ int main(int argc, char** argv)
> {
> int opt_mappings = 0;
> int opt_preload = 1;
> + int opt_share = 0;
> char *opt_library = NULL;
>
> char opts[] = "+hv";
> @@ -333,6 +337,7 @@ int main(int argc, char** argv)
> required_argument, NULL, LONG_LIBRARY},
> {"library-use-path",
> no_argument, NULL, LONG_NO_LIBRARY},
> + {"share-text", no_argument, NULL, LONG_SHARE},
>
> {"disable", optional_argument, NULL, MAP_BASE|MAP_DISABLE},
> {"text", optional_argument, NULL, MAP_BASE|MAP_TEXT},
> @@ -387,6 +392,10 @@ int main(int argc, char** argv)
> opt_library = optarg;
> break;
>
> + case LONG_SHARE:
> + opt_share = 1;
> + break;
> +
> case -1:
> break;
>
> @@ -414,6 +423,9 @@ int main(int argc, char** argv)
> if (opt_preload)
> ldpreload(opt_mappings);
>
> + if (opt_share)
> + setup_environment("HUGETLB_SHARE", "1");
> +
> if (opt_dry_run)
> exit(EXIT_SUCCESS);
>
The manual page for hugectl also has to be updated.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
