On Thu, May 14, 2009 at 08:41:15AM +0100, Eric B. Munson wrote:
> On Wed, 13 May 2009, David Gibson wrote:
> 
> > On Wed, May 13, 2009 at 10:35:53AM +0100, Eric B. Munson wrote:
> > > The readahead, madvise, and the fadvise tests can all hang the running 
> > > machine
> > > if the kernel bug they are testing is present.  This patch wraps these 
> > > tests
> > > so that they fail without running if the kernel version is less than
> > > 2.6.30.
> > 
> > Is there a way to force the tests to run for real?  There really needs
> > to be this so you can test (for example) a distro kernel with
> > backported patches for the bugs in question.
> 
> It is possible to run the test by hand, this just has it skip them
> when run through run_tests.py.

Hrm, ok.  I'd still suggest a "run_tests.py -f" or something to make
it run all the tests.

> > Although it's further proliferating the number of test results, I'd
> > also suggest making this say something other than just FAIL, as a hint
> > that the tests aren't actually running, just assuming a result from
> > the kernel version.  "FAIL (assumed)" maybe?
> 
> I will work up a patch that adds this.

Excellent.  Btw, I'm probably going to be doing some more hugepage
work later this year (kernel side, port to new hardware), so at some
point I should sync up with you and Mel on the way things are done
these days in libhugetlbfs - it seems to have changed a bit since I
was last active.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: Digital signature

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to