On Mon, Jun 15, 2009 at 10:23:06AM +0200, Dan Hor?k wrote: > Hello, > > I have 2 patches that enables building libhugetlbfs on s390/s390x and > ia64 architectures. > > libhugetlbfs-2.3-drop-s390.patch > - simple patch to drop the s390 31/32 bits from the build, the problem > is that current gcc in Fedora/s390x is built without the 31/32 bit > support and most likely other distros will be focusing on the 64-bit > port only > > libhugetlbfs-2.4-Makefile.patch > - a better patch that splits the s390 and s390x cases and fixes the > library path on ia64 >
To my eyes, the s390 fix looks ok. As you say, the 31/32 bit support on that platform is unlikely to be interesting. On the library path change. I see the FHS says that the path is lib for 64-bit libraries on IA-64 and the change looks ok. However, do we know if the majority of distributions obey this? > Fedora related bug: https://bugzilla.redhat.com/show_bug.cgi?id=501690 > > > Thanks > Dan Horak > > -- > Fedora and Red Hat package maintainer > diff -Nrup libhugetlbfs-2.3.orig/Makefile libhugetlbfs-2.3/Makefile > --- libhugetlbfs-2.3.orig/Makefile 2009-04-09 15:11:35.000000000 +0200 > +++ libhugetlbfs-2.3/Makefile 2009-05-20 12:15:31.000000000 +0200 > @@ -71,9 +71,7 @@ CFLAGS += -DNO_ELFLINK > else > ifeq ($(ARCH),s390x) > CC64 = gcc -m64 > -CC32 = gcc -m31 > TMPLIB64 = lib64 > -TMPLIB32 = lib > CFLAGS += -DNO_ELFLINK > else > $(error "Unrecognized architecture ($(ARCH))") > --- libhugetlbfs-2.4/Makefile.s390 2009-05-29 10:55:35.000000000 +0200 > +++ libhugetlbfs-2.4/Makefile 2009-06-03 11:21:27.000000000 +0200 > @@ -61,7 +61,7 @@ endif > else > ifeq ($(ARCH),ia64) > CC64 = gcc > -TMPLIB64 = lib64 > +TMPLIB64 = lib > CFLAGS += -DNO_ELFLINK > else > ifeq ($(ARCH),sparc64) > @@ -71,8 +71,11 @@ CFLAGS += -DNO_ELFLINK > else > ifeq ($(ARCH),s390x) > CC64 = gcc -m64 > -CC32 = gcc -m31 > TMPLIB64 = lib64 > +CFLAGS += -DNO_ELFLINK > +else > +ifeq ($(ARCH),s390) > +CC32 = gcc -m31 > TMPLIB32 = lib > CFLAGS += -DNO_ELFLINK > else > @@ -84,6 +87,7 @@ endif > endif > endif > endif > +endif > > ifdef CC32 > OBJDIRS += obj32 -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
