I think the gethugepagesizes testcase is buggy. Specifically, it
tests the calls to retreieve the available page sizes against faked up
sysfs contents. This includes testing that the gethugepagesizes()
call doesn't return more entries than the maximum it's given (which
might clobber memory).
But, validate_sizes() checks that the n returned entries exactly match
the first n expected entries, even when the maxmum number of entries
to return is smaller than the total number of pagesizes available. I
don't see that there's any guarantee on the order gethugepagesizes()
will return it's things, so if entries are truncated there's no
guarantee that we won't lose entries that are in the first n expected
(getting entries from above n in the expected list instead).
As far as I can tell, this has just been working by accident since
forever. Except it's failing on the system I'm testing right now.
I'll send a patch to fix this if I get to it, but it's not my first
priority right now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
