The linkhuge_nofd testcase no longer tests what it's supposed to -
that the elflink code will correctly fall back to normal pages if
hugepages are not available.
The testcase checked this path by overriding the
hugetlbfs_unlinked_fd() function with one that always fails. However
newer revisions of the elflink code don't use the
hugetlbfs_unlinked_fd() function, they use the lower level
hugetlbfs_unlinked_fd_for_size().
This patch overrides the correct function and make the testcase do
what it's supposed to. Currently the test is effectively a duplicate
of the main linkhuge test.
Index: libhugetlbfs/tests/linkhuge_nofd.c
===================================================================
--- libhugetlbfs.orig/tests/linkhuge_nofd.c 2009-10-02 15:33:38.000000000
+1000
+++ libhugetlbfs/tests/linkhuge_nofd.c 2009-10-02 15:34:06.000000000 +1000
@@ -26,7 +26,7 @@
#include "hugetests.h"
/* Override the working version from libhugetlbfs */
-int hugetlbfs_unlinked_fd(void)
+int hugetlbfs_unlinked_fd_for_size(long page_size)
{
return -1;
}
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
