On Wed, Jun 15, 2011 at 10:29:26AM -0400, Eric B Munson wrote: > On Wed, 15 Jun 2011, Andrew Hastings wrote:
> > My opinion: There's no reason for HUGETLB_MORECORE=thp to _not_ do
> > the madvise. HUGETLB_MORECORE=thp should be implemented as a
> > wrapper around sbrk; it should _not_ add a gap to the heap.
Absolutely. Presumably the madvise() won't hurt, even when it's not
necessary.
> I am fine having madvise be the default and the next version will do it this
> way. I don't think the loss of 2m-4k of address space (only) is a big enough
> issue to justify having thp implement a completely new morecore hook.
I really see no reason not to always madvise(), not even as an option.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
