On Wed, 20 Jul 2011, Andrew Hastings wrote:

> Eric,
> 
> On 07/11/11 10:51, Eric B Munson wrote:
> > Transparent huge pages (THP) make using huge pages on x86(_64) incredibly 
> > easy.
> > However, the standard glibc malloc is not setup to optimixe allocations to 
> > be
> > fulfilled as THP, relying on khugepaged to scan and merge huge pages when
> > possible.  This patch set extends the morecore idea that was originally 
> > used to
> > back the heap with hugetlbfs huge pages to ensure that the heap is grown in
> > huge page sized increments.  This allows the kernel allocator to start the 
> > new
> > area as a huge page rather than wait for promotion.
> > 
> > Eric B Munson (3):
> >   Add support for THP in morecore
> >   Add support to hugeadm for configuring transparent huge pages
> >   Add controls to hugectl for new THP related env variables
> > 
> >  HOWTO                   |    7 +++-
> >  hugeadm.c               |  105 
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >  hugectl.c               |   17 +++++++-
> >  hugeutils.c             |    4 ++
> >  libhugetlbfs_internal.h |    1 +
> >  man/hugeadm.8           |   35 ++++++++++++++++
> >  man/hugectl.8           |   11 +++++
> >  morecore.c              |   84 +++++++++++++++++++++++++++++++++++--
> >  8 files changed, 258 insertions(+), 6 deletions(-)
> 
> Please consider adding some test cases.
> 
> -Andrew Hastings
>  Cray Inc.

I agree that test cases are a good thing for new functionality, but I don't see
what could be tested.  THP availablility is completely up to the kernel, this
method doesn't guarantee that the heap will be on huge pages, it only aligns
allocations so that if there are THP available, they will be used without
having to wait for khugepaged to merge them.  So I suppose we could test that
every call to brk is 2MB aligned, but I don't see how that could ever fail.

Eric
> 

Attachment: signature.asc
Description: Digital signature

------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the 
BlackBerry® mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry® DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1 
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to