On Mon, 10 Sep 2012, Jan Stancek wrote:

> This testcase failed on some setups (ppc64):
>   Starting testcase "./obj64/mremap-expand-slice-collision", pid 10840
>   do_readback(0x20001000000, 0x1000000, "huge above")
>   do_readback(0x1ffffff0000, 0x10000, "normal below")
>   Attempting to remap...disallowed
>   do_readback(0x20001000000, 0x10000, "normal above")
>   FAIL    mmap(huge below): Device or resource busy
> 
> Problem is that SLICE_BOUNDARY was hardcoded to 0x20000000000.
> When testcase tries to mmap huge page below this address (0x1ffff000000),
> it fails with EBUSY because there is already heap (0x1????000000)
> at this slice which may not be using huge pages.
> 
> See also kernel commit. which introduced slices on powerpc:
>   commit d0f13e3c20b6fb73ccb467bdca97fa7cf5a574cd
>   Author: Benjamin Herrenschmidt <b...@kernel.crashing.org>
>   Date:   Tue May 8 16:27:27 2007 +1000
>       [POWERPC] Introduce address space "slices"
> 
> This patch removes hardcoded SLICE_BOUNDARY address and introduces
> function to find two free neighbour slices at runtime. Slice boundary
> is then set to address between these slices.
> 
> With patch:
>   Starting testcase "./obj64/mremap-expand-slice-collision", pid 12768
>   can't use slice_boundary: 0x20000000000
>   using slice_boundary: 0x30000000000
>   do_readback(0x30001000000, 0x1000000, "huge above")
>   do_readback(0x2ffffff0000, 0x10000, "normal below")
>   Attempting to remap...disallowed
>   do_readback(0x30001000000, 0x10000, "normal above")
>   do_readback(0x2ffff000000, 0x1000000, "huge below")
>   Attempting to remap...disallowed
>   PASS
> 
> Signed-off-by: Jan Stancek <jstan...@redhat.com>

Applied, thanks.
Eric

Attachment: signature.asc
Description: Digital signature

------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
Libhugetlbfs-devel mailing list
Libhugetlbfs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel

Reply via email to