On 3 May 2014 21:39, Munson, Eric <emun...@mgebm.net> wrote: > On 2014-05-03 03:28, Fathi Boudra wrote: >> >> This patch allow to override CC and use it for aarch64 case like the >> other architectures. >> >> Signed-off-by: Fathi Boudra <fathi.bou...@linaro.org> >> --- >> Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 91502e1..5aa1e12 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -33,7 +33,7 @@ CFLAGS += -Wall -fPIC >> CPPFLAGS += -D__LIBHUGETLBFS__ >> >> ARCH = $(shell uname -m | sed -e s/i.86/i386/) >> -CC = gcc >> +CC ?= gcc > > > Is this change because you regularly assign CC at the command line? I only > ask because the other rules work without it so I don't understand why it is > necessary.
Yes, the build system used by distributions does. Usually, the compiler and the build flags are passed. In a native build, you aren't affected but if you cross compile, you can't set the cross-compiler properly since it's hardcoded. >> >> CUSTOM_LDSCRIPTS = yes >> >> @@ -66,7 +66,7 @@ ELF32 += armelf_linux_eabi >> CUSTOM_LDSCRIPTS = no >> else >> ifneq (,$(findstring aarch64,$(ARCH))) >> -CC64 = gcc >> +CC64 = $(CC) > > > The other architectures specify -m64 to the compiler to signal a 64 bit > compile. I am unfamiliar with ARM64 so forgive me if this isn't relevant, > but don't you want to do the same thing? -m64 isn't a valid option for GCC on Aarch64: http://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html#AArch64-Options > >> ELF64 = aarch64elf >> TMPLIB64 = lib64 >> CUSTOM_LDSCRIPTS = no ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
