On 2014-11-10 09:43, Gary Robertson wrote: > Line 35 of the Makefile works in the case of native build > environments, but the patch I sent is required for proper > functionality when cross-compiling for different x86 arches. > On my x86_64 platform the make fails for i586 unless my patch is > included. Do I need to resubmit the patch with these details added in > the rationale for applying the patch? > > Gary Robertson
Don't worry about resubmitting, I will apply with the added rationale. Eric > > On Thu, Nov 6, 2014 at 12:13 PM, Eric B Munson <emun...@mgebm.net> > wrote: > >> On Thu, 06 Nov 2014, Gary S. Robertson wrote: >> >>> From: "Gary S. Robertson" <gary.robert...@linaro.org> >>> >>> The makefile only recognized i386 or x86_64 arches. Added >> support >>> to recognize i486, i586, i686. >>> >>> Signed-off-by: Gary S. Robertson <gary.robert...@linaro.org> >>> --- >>> Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Makefile b/Makefile >>> index 91502e1..0bfaee8 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -71,7 +71,7 @@ ELF64 = aarch64elf >>> TMPLIB64 = lib64 >>> CUSTOM_LDSCRIPTS = no >>> else >>> -ifeq ($(ARCH),i386) >>> +ifneq (,$(filter i386 i486 i586 i686,$(ARCH))) >> >> This is not necessary, line 35 of the Makfile covers the i.86 case. >> >>> CC32 = $(CC) >>> ELF32 = elf_i386 >>> TMPLIB32 = lib >>> -- >>> 1.7.9.5 >>> >>> >>> >> > ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Libhugetlbfs-devel mailing list >>> Libhugetlbfs-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel >> [1] >>> > > > > Links: > ------ > [1] https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel ------------------------------------------------------------------------------ _______________________________________________ Libhugetlbfs-devel mailing list Libhugetlbfs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libhugetlbfs-devel
