On Fri, 30 Nov 2007, Benjamin Kirk wrote:

> **please read if you want to be able to read your existing restart files!**

This line should probably be repeated with more boldface, caps, and
exclamation points.

On the other hand, it would be better if we could make the default
behavior more user-friendly.  Instead of testing for the presence of a
--read_legacy command line switch, why can't we test for the absense
of that new version line at the beginning of the file?

Otherwise, very nice work.  We don't support writing the Mesh in
parallel yet, right; just the EquationSystems?  It seems like you've
been doing the harder of the two tasks first!

> Now, currently the hilbert indices are temporarily stored in the
> DofObject::id() locations.  This requires overwriting the valid numbering
> with an invalid numbering

Based on the changes I had to make for ParallelMesh, I don't think
any numbering counts as "invalid" anymore unless it's actually
non-contiguous, and even that only breaks on some of our output code.

Of course, you probably just changed MeshData's status from "broken in
parallel" to "really broken in parallel", but one thing at a time.

> and then restoring the original.

As far as the library code is concerned we should be able to get away
without restoring the original, but it's good that you did; better to
do some unnecessary work than to violate the Rule of Least Surprise.

> it for a while and chose this approach over adding a
> DofObject::global_id() or something like that, although that may be
> something to consider for the future.

No; you made the right choice.
---
Roy

-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to