Ok - I went ahead and committed that so that I can work on the next step... which is allowing you to attach a Preconditioner to the linear solver. But now we need some discussion on that.
First, do we want to support the old style of specifying a preconditioner type for a LinearSolver? Or should we just do away with that altogether in favor of instantiating a Preconditioner class.... setting its type and attaching it to the LinearSolver. I don't have feelings either way. It seems as if allowing you to set a preconditioner type is a useful shortcut for a common operation... but at the same time it does duplicate functionality. Along these same lines... if we keep the preconditioner type setting capability should the linear solvers build Preconditioners and set their appropriate type? Or should we continue to do everything the way we currently do unless you specifically attach a Preconditioner object to the linear solver? Derek On Feb 6, 2009, at 2:55 PM, John Peterson wrote: > On Fri, Feb 6, 2009 at 2:45 PM, Derek Gaston <[email protected]> > wrote: >> So... I've got the initial Preconditioner class and a >> PetscPreconditioner >> class based on it all coded up and working with my current code. >> I've >> attached the diff with all of the changes. If no one sees anything >> big I'll >> go ahead and commit it then we can talk about the next move. >> Currently, I haven't modified any internal bits that would impact >> anyone... >> the changes are pretty much just adding the new files. The largest >> actual >> change was probably moving set_petsc_preconditioner_type from >> PetscLinearSolver to PetscPreconditioner. >> Derek > > Patch looks good after a quick read-through. > > -- > John ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
