Sorry, my last email was not complete, I hit the return key by mistake :-)

So, some comments/questions about the SLEPc section of Make.common.in

* lines 386-394 *

for slepc 2.3.3, what's the use of including this file?

include $(SLEPC_DIR)/bmake/$(PETSC_ARCH)/slepcconf (line 387)

This file only has the variable SLEPC_INSTALL_DIR (at least in my
compilations), which isn't used anywhere. And below, on line 409, we
have:

libs-SLEPC = -L$(SLEPC_LIB) -lslepc

I wonder where $(SLEPC_LIB) comes from (everything is working though).
Uhmm, maybe we just need the switch "-lslepc" and the variable is
actually empty...

UPDATE: slepcconf is probably used because of $(ARPACK_LIB) (line
412), in case we use arpack.




lines 398-407
What's the use of defining the variable PETSC_LIB here? It isn't used
at all and it will be defined again in the PETSc section (lines
419-515). It looks like a copy-paste that was not corrected.



lines 520-524 (after the PETSc section)
We have:

  ifeq ($(enable-slepc),yes)
    ifeq ($(petsc-major-minor),2.3.x)  # 2.3.x & newer style
      include $(SLEPC_DIR)/bmake/slepc_common_variables
    endif
  endif

This part is related to SLEPc, why not put it with the rest? (it
should substitute line 387, to be coherent with version 3.0).

Paulo

Attachment: patch_makecommonin
Description: Binary data

------------------------------------------------------------------------------
_______________________________________________
Libmesh-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to