I committed the first patch without changes; thank you very much!

Would you mind if I futzed with the names on this one?  E.g.

#  if PETSC_VERSION_LESS_THAN(2,2,1)         // Cannot avoid a copy
#    define LibMeshISCreate(comm,n,idx,is) 
ISCreateGeneral((comm),(n),(idx),(is))
#  else
#    define LibMeshISCreate(comm,n,idx,is) 
ISCreateGeneralWithArray((comm),(n),(idx),(is))
#  endif

"Overloading" a C function with a macro of the same name is confusing
to me; likewise for a PETSC_USE_POINTER name that turns out not to
correspond to any symbol or macro in PETSc.
---
Roy

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Libmesh-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to