On Tue, Aug 9, 2011 at 4:24 PM, Roy Stogner <[email protected]> wrote: > > I want to run this by everyone before committing. I personally think > that [compiling cleanly in opt mode with extra warnings enabled] is > important enough to be worth [wrapping tons of function arguments in > libmesh_debug_var()], but I want to give more than just John and I a > chance to chime in about the changes. I didn't realize there were *so > many* such arguments. I guess we've got lots of cases where a virtual > function has arguments which we intend for use by only some > subclasses, but for which we assert consistency in other subclasses.
A problem I see with this (other than adding a lot of code just to silence the compiler) is that it won't be maintained by all (any?) of the developers. I for one do not plan to add extra warnings to compiler flags in opt mode, and don't recommend we do so by default either... -- John ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ Libmesh-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-devel
