On Mon, Jun 4, 2012 at 10:56 AM, John Peterson <jwpeter...@gmail.com> wrote:
> On Mon, Jun 4, 2012 at 10:36 AM, Kirk, Benjamin (JSC-EG311)
> <benjamin.kir...@nasa.gov> wrote:
>>>> Probably not a coincidence that it dies in a call to the Partitioner?
>>>>
>>>> I'm compiling in DEBUG mode to get more information, but perhaps we
>>>> should just revert r5654 (or move it to an unstable branch) if it
>>>> didn't actually fix the problem of partitioning small meshes?
>>>
>>> I'm getting the same segfault without that patch and am investigating too...
>>>
>>> Let's see if we can fix the issue on trunk relatively quickly before
>>> reverting the long overdue update.
>>
>> Perhaps the bad cast is unrelated and may be because of some debugging code
>> that slipped through:
>>
>> See line 409:
>>
>> ParallelMesh& pmesh = dynamic_cast<ParallelMesh&>(mesh);
>>  pmesh.libmesh_assert_valid_parallel_ids();
>>
>> Of course that will fail if you're not running with a parallel mesh.  I'm
>> guessing Roy tested it with a parallel mesh and all was happy.
>>
>> I've changed the code to cast instead to a pointer.  If that fails it
>> returns a NULL pointer instead of issuing a runtime exception.
>
> Indeed, I was configure'd without parallel mesh.
>
> Your patch seems to have fixed the issue for me.
>
> I can also check in the LIBMESH_TLS patch if you have a chance to test
> it out on a linux box.....

BTW, since Metis is using OpenMP (no raw pthreads that I can see) the
proper TLS mechanism is probably something like

#pragma omp threadprivate(var)

I feel like my patch (which effectively makes those variables global)
will potentially break anyone actually running libmesh with
OMP_NUM_THREADS > 1.

Not sure how much work this would be to fix and test.  Should we just
notify the Metis developers?

-- 
John

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel

Reply via email to